Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pycamera & vcnl4020 libraries #447

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Fix pycamera & vcnl4020 libraries #447

merged 2 commits into from
Dec 6, 2023

Conversation

jepler
Copy link
Member

@jepler jepler commented Dec 6, 2023

vcnl4020 was originally added in the wrong spot. I removed it, because I saw other vcnl40x0 and thought it was already in the right spot as well. this restores it to the right spot.

pycamera didn't release, possibly because its URL was in the wrong form in .gitmodules.

I was wrong that this was also in the correct location; other VCNL40x0
drivers were, but this one was not.

This was incorrectly removed in ca9cd21
this may have prevented the library from being released
@jepler jepler requested a review from FoamyGuy December 6, 2023 19:51
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you!

@FoamyGuy FoamyGuy merged commit cac964c into main Dec 6, 2023
2 checks passed
@dhalbert dhalbert deleted the fix-pycamera-vcnl4020 branch December 6, 2023 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants